From: Christian Borntraeger <borntraeger@de.ibm.com>
Date: Thu, 18 Dec 2014 09:04:17 +0000 (+0100)
Subject: s390x/kvm: unknown DIAGNOSE code should give a specification exception
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=68540b1a1b505d9578699b03fe0b5da716a21dcc;p=qemu.git

s390x/kvm: unknown DIAGNOSE code should give a specification exception

As described in CP programming services an unimplemented DIAGNOSE
function should return a specification exception. Today we give the
guest an operation exception.
As both exception types are suppressing and Linux as a guest does not
care about the type of program check in its exception table handler
as long as both types have the same kind of error handling (nullifying,
terminating, suppressing etc.) this was unnoticed.

Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 6bf2719c43..6f2d5b4924 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -1091,7 +1091,7 @@ static int handle_diag(S390CPU *cpu, struct kvm_run *run, uint32_t ipb)
         break;
     default:
         DPRINTF("KVM: unknown DIAG: 0x%x\n", func_code);
-        r = -1;
+        enter_pgmcheck(cpu, PGM_SPECIFICATION);
         break;
     }