From: Axel Lin Date: Wed, 19 May 2021 13:22:55 +0000 (+0800) Subject: regulator: Check ramp_delay_table for regulator_set_ramp_delay_regmap X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=687c9e3b1a81d43b233482f781bd4e20561bc390;p=linux.git regulator: Check ramp_delay_table for regulator_set_ramp_delay_regmap Return -EINVAL if ramp_delay_table is NULL. Also add WARN_ON since the driver code needs fix if this happened. Signed-off-by: Axel Lin Link: https://lore.kernel.org/r/20210519132255.1683863-1-axel.lin@ingics.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index 0e16e31c968f1..ad2237a95572a 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -948,7 +948,7 @@ int regulator_set_ramp_delay_regmap(struct regulator_dev *rdev, int ramp_delay) int ret; unsigned int sel; - if (!rdev->desc->n_ramp_values) + if (WARN_ON(!rdev->desc->n_ramp_values || !rdev->desc->ramp_delay_table)) return -EINVAL; ret = find_closest_bigger(ramp_delay, rdev->desc->ramp_delay_table,