From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mon, 20 Mar 2023 04:23:25 +0000 (-0700)
Subject: Input: iqs62x-keys - suppress duplicated error message in .remove()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6906f5060d39f95aa0be30e998e0cc1179ba3d04;p=linux.git

Input: iqs62x-keys - suppress duplicated error message in .remove()

If a platform driver's remove callback returns non-zero the driver core
emits an error message. In such a case however iqs62x_keys_remove()
already issued a (better) message. So return zero to suppress the
generic message.

This patch has no other side effects as platform_remove() ignores the
return value of .remove() after the warning.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230318225110.261439-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

diff --git a/drivers/input/keyboard/iqs62x-keys.c b/drivers/input/keyboard/iqs62x-keys.c
index db793a550c258..02ceebad7bdaa 100644
--- a/drivers/input/keyboard/iqs62x-keys.c
+++ b/drivers/input/keyboard/iqs62x-keys.c
@@ -320,7 +320,7 @@ static int iqs62x_keys_remove(struct platform_device *pdev)
 	if (ret)
 		dev_err(&pdev->dev, "Failed to unregister notifier: %d\n", ret);
 
-	return ret;
+	return 0;
 }
 
 static struct platform_driver iqs62x_keys_platform_driver = {