From: Hans Verkuil Date: Fri, 13 May 2022 07:54:43 +0000 (+0100) Subject: media: cec-adap.c: log when claiming LA fails unexpectedly X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=691c3db0dc7616b3cc4ff0f52f956c9afa71b1cd;p=linux.git media: cec-adap.c: log when claiming LA fails unexpectedly If there is a hardware problem such as someone pulling the CEC line low continuously, then the POLL message will fail with an error other than OK, NACK, ABORTED or TIMEOUT. Log the tx_status value in that case to help debug this. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/cec/core/cec-adap.c b/drivers/media/cec/core/cec-adap.c index 8bf91b5a7d0e6..41a79293ee02d 100644 --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1309,8 +1309,11 @@ static int cec_config_log_addr(struct cec_adapter *adap, * we assume that something is really weird and that it is not a * good idea to try and claim this logical address. */ - if (i == max_retries) + if (i == max_retries) { + dprintk(0, "polling for LA %u failed with tx_status=0x%04x\n", + log_addr, msg.tx_status); return 0; + } /* * Message not acknowledged, so this logical