From: Bartosz Golaszewski <bartekgola@gmail.com>
Date: Tue, 13 Jun 2017 20:04:13 +0000 (+0200)
Subject: tests: iter: fix potential segfault
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6a26582df3103993e69ea2b9309929bc010f9ca2;p=qemu-gpiodev%2Flibgpiod.git

tests: iter: fix potential segfault

All automatically cleaned up variables must be initialized. Otherwise
we risk calling free() on an uninitialized pointer if an assertion
fails before we assign it a value.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
---

diff --git a/tests/tests-iter.c b/tests/tests-iter.c
index b4f49ba..daee771 100644
--- a/tests/tests-iter.c
+++ b/tests/tests-iter.c
@@ -44,9 +44,9 @@ static void chip_iter_noclose(void)
 {
 	TEST_CLEANUP(test_free_chip_iter_noclose)
 			struct gpiod_chip_iter *iter = NULL;
-	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipA;
-	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipB;
-	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipC;
+	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipA = NULL;
+	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipB = NULL;
+	TEST_CLEANUP(test_close_chip) struct gpiod_chip *chipC = NULL;
 	struct gpiod_chip *chip;
 	bool A, B, C;