From: Alexandru Ardelean Date: Fri, 1 Nov 2019 09:35:00 +0000 (+0200) Subject: iio: imu: adis: check ret val for non-zero vs less-than-zero X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6a39ab3b195c125d3fe49d0b0b613c2e1dbbc5a2;p=linux.git iio: imu: adis: check ret val for non-zero vs less-than-zero The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index 1631c255deab1..dc2f9e061d983 100644 --- a/drivers/iio/imu/adis.c +++ b/drivers/iio/imu/adis.c @@ -286,7 +286,7 @@ int adis_check_status(struct adis *adis) int i; ret = adis_read_reg_16(adis, adis->data->diag_stat_reg, &status); - if (ret < 0) + if (ret) return ret; status &= adis->data->status_error_mask;