From: Chuhong Yuan Date: Thu, 19 Dec 2019 07:48:24 +0000 (+0100) Subject: media: exynos4-is: add missed clk_disable_unprepare in remove X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6b212c0cd5c95fccb69f961284b0fa71ee2260f1;p=linux.git media: exynos4-is: add missed clk_disable_unprepare in remove This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare() to fix it. Signed-off-by: Chuhong Yuan Reviewed-by: Krzysztof Kozlowski Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c index e87c6a09205bd..17de14fbba317 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite.c +++ b/drivers/media/platform/exynos4-is/fimc-lite.c @@ -1614,6 +1614,9 @@ static int fimc_lite_remove(struct platform_device *pdev) struct fimc_lite *fimc = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; + if (!pm_runtime_enabled(dev)) + clk_disable_unprepare(fimc->clock); + pm_runtime_disable(dev); pm_runtime_set_suspended(dev); fimc_lite_unregister_capture_subdev(fimc);