From: Jiri Pirko <jiri@nvidia.com>
Date: Fri, 10 Feb 2023 10:01:31 +0000 (+0100)
Subject: devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value... 
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6b4bfa43ce29165fb0a2a8ef770d94c1d93e5ad8;p=linux.git

devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value_set()

Driver calling devl_param_driverinit_value_set() has to hold devlink
instance lock while doing that. Put an assertion there.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
index d4c896f899056..3569706c49e11 100644
--- a/net/devlink/leftover.c
+++ b/net/devlink/leftover.c
@@ -9681,6 +9681,8 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
 {
 	struct devlink_param_item *param_item;
 
+	devl_assert_locked(devlink);
+
 	param_item = devlink_param_find_by_id(&devlink->params, param_id);
 	if (WARN_ON(!param_item))
 		return;