From: Artem Chernyshev Date: Thu, 3 Aug 2023 14:54:17 +0000 (+0300) Subject: fs: ocfs2: namei: check return value of ocfs2_add_entry() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6b72e5f9e79360fce4f2be7fe81159fbdf4256a5;p=linux.git fs: ocfs2: namei: check return value of ocfs2_add_entry() Process result of ocfs2_add_entry() in case we have an error value. Found by Linux Verification Center (linuxtesting.org) with SVACE. Link: https://lkml.kernel.org/r/20230803145417.177649-1-artem.chernyshev@red-soft.ru Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem") Signed-off-by: Artem Chernyshev Reviewed-by: Joseph Qi Cc: Artem Chernyshev Cc: Joel Becker Cc: Kurt Hackel Cc: Mark Fasheh Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Signed-off-by: Andrew Morton --- diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 17c52225b87d4..03bccfd183f3c 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap, status = ocfs2_add_entry(handle, new_dentry, old_inode, OCFS2_I(old_inode)->ip_blkno, new_dir_bh, &target_insert); + if (status < 0) { + mlog_errno(status); + goto bail; + } } old_inode->i_ctime = current_time(old_inode);