From: Chris Nisbet Date: Fri, 24 Jan 2020 17:43:14 +0000 (+1300) Subject: iter: remove unnecessary indirection in free_dirs X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6d486c0016dc9bf4274220813d5c6e7934589430;p=qemu-gpiodev%2Flibgpiod.git iter: remove unnecessary indirection in free_dirs It is not necessary to pass the address of the 'dirs' variable to dirs_free(), so this commit removes the unecessary indirection. Signed-off-by: Chris Nisbet Signed-off-by: Bartosz Golaszewski --- diff --git a/lib/iter.c b/lib/iter.c index a4d883a..bfd2852 100644 --- a/lib/iter.c +++ b/lib/iter.c @@ -28,13 +28,13 @@ static int dir_filter(const struct dirent *dir) return !strncmp(dir->d_name, "gpiochip", 8); } -static void free_dirs(struct dirent ***dirs, unsigned int num_dirs) +static void free_dirs(struct dirent **dirs, unsigned int num_dirs) { unsigned int i; for (i = 0; i < num_dirs; i++) - free((*dirs)[i]); - free(*dirs); + free(dirs[i]); + free(dirs); } struct gpiod_chip_iter *gpiod_chip_iter_new(void) @@ -69,7 +69,7 @@ struct gpiod_chip_iter *gpiod_chip_iter_new(void) goto err_close_chips; } - free_dirs(&dirs, num_chips); + free_dirs(dirs, num_chips); return iter; @@ -85,7 +85,7 @@ err_free_iter: free(iter); err_free_dirs: - free_dirs(&dirs, num_chips); + free_dirs(dirs, num_chips); return NULL; }