From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 6 Jan 2023 06:33:59 +0000 (-0800)
Subject: devlink: don't require setting features before registration
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6ef8f7da92750c3c25755fac39b561fff2d47378;p=linux.git

devlink: don't require setting features before registration

Requiring devlink_set_features() to be run before devlink is
registered is overzealous. devlink_set_features() itself is
a leftover from old workarounds which were trying to prevent
initiating reload before probe was complete.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/devlink/core.c b/net/devlink/core.c
index 7cf0b3efbb2f9..a31a317626d75 100644
--- a/net/devlink/core.c
+++ b/net/devlink/core.c
@@ -125,8 +125,6 @@ next:
  */
 void devlink_set_features(struct devlink *devlink, u64 features)
 {
-	ASSERT_DEVLINK_NOT_REGISTERED(devlink);
-
 	WARN_ON(features & DEVLINK_F_RELOAD &&
 		!devlink_reload_supported(devlink->ops));
 	devlink->features = features;