From: John Snow <jsnow@redhat.com>
Date: Fri, 24 Jul 2020 05:22:59 +0000 (-0400)
Subject: ide: clear interrupt on command write
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6f52e69f468f3b75db0292be3ee479db699a9a57;p=qemu.git

ide: clear interrupt on command write

Not known to fix any bug, but I couldn't help but notice that ATA
specifies that writing to this register should clear an interrupt.

ATA7: Section 5.3.3 (Command register - Effect)
ATA6: Section 7.4.4 (Command register - Effect)
ATA5: Section 7.4.4 (Command register - Effect)
ATA4: Section 7.4.4 (Command register - Effect)
ATA3: Section 5.2.2 (Command register)

Other editions: try searching for the phrase "Writing this register".

Signed-off-by: John Snow <jsnow@redhat.com>
---

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 8a55352e4b..0d745d63a1 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1312,6 +1312,7 @@ void ide_ioport_write(void *opaque, uint32_t addr, uint32_t val)
     default:
     case ATA_IOPORT_WR_COMMAND:
         ide_clear_hob(bus);
+        qemu_irq_lower(bus->irq);
         ide_exec_cmd(bus, val);
         break;
     }