From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Fri, 14 Jun 2024 13:28:10 +0000 (+0200)
Subject: hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22)
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7028187bd003f62e11f41cc8c6a26c1c12755cad;p=qemu.git

hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22)

Per sections 3.6.1 (SD Bus Protocol), 4.3.4 "Data Write"
and 7.3.2 (Responses):

  In the CMD line the Most Significant Bit is transmitted first.

Use the stl_be_p() helper to store the value in big-endian.

Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240628070216.92609-9-philmd@linaro.org>
---

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 1e9530f9ae..54bb0ff1c9 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1669,8 +1669,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd,
     case 22:  /* ACMD22: SEND_NUM_WR_BLOCKS */
         switch (sd->state) {
         case sd_transfer_state:
-            *(uint32_t *) sd->data = sd->blk_written;
-
+            stl_be_p(sd->data, sd->blk_written);
             sd->state = sd_sendingdata_state;
             sd->data_start = 0;
             sd->data_offset = 0;