From: Christophe JAILLET Date: Thu, 9 Nov 2017 17:09:29 +0000 (+0100) Subject: video: fbdev: au1200fb: Fix incorrect IRQ freeing X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=703a4af427a9bf3028f1a9369fcec7bfcf56f0ed;p=linux.git video: fbdev: au1200fb: Fix incorrect IRQ freeing 'au1200fb_drv_probe()' can not fail after a successful call to 'request_irq()'. So there is no point to call 'free_irq()' in the error handling path. Moreover, the hard coded AU1200_LCD_INT looks boggus since commit 1630d85a8312 ("au1200fb: fix hardcoded IRQ"). So, remove it. Signed-off-by: Christophe JAILLET Cc: Tejun Heo [b.zolnierkie: patch summary and description fixups] Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c index cf54168d44dc7..0d8ed0ef91839 100644 --- a/drivers/video/fbdev/au1200fb.c +++ b/drivers/video/fbdev/au1200fb.c @@ -1766,8 +1766,6 @@ failed: fb_dealloc_cmap(&fbi->cmap); kfree(fbi->pseudo_palette); } - if (plane == 0) - free_irq(AU1200_LCD_INT, (void*)dev); return ret; }