From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 11 Jul 2019 14:10:37 +0000 (+0800)
Subject: scsi: lpfc: Remove unnecessary null check before kfree
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=70a51d8c53176080e82b2aef050f820ccdd4b3f8;p=linux.git

scsi: lpfc: Remove unnecessary null check before kfree

A null check before a kfree is redundant, so remove it.  This is detected
by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b7216d694bff1..c7f66239ca702 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1276,9 +1276,7 @@ lpfc_bsg_hba_set_event(struct bsg_job *job)
 	return 0; /* call job done later */
 
 job_error:
-	if (dd_data != NULL)
-		kfree(dd_data);
-
+	kfree(dd_data);
 	job->dd_data = NULL;
 	return rc;
 }