From: Stefan Weil <weil@mail.berlios.de>
Date: Sun, 3 Apr 2011 16:22:45 +0000 (+0200)
Subject: darwin-user: Remove unneeded null pointer check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=70afb8ff90e9d922ed729e6dbabaff6d67c461aa;p=qemu.git

darwin-user: Remove unneeded null pointer check

cppcheck reports this error:

commpage.c:223: error: Possible null pointer dereference:
value - otherwise it is redundant to check if value is null at line 214

The null pointer check in line 214 is indeed not needed.
If value were null, the code would crash in line 223.
See do_compare_and_swap64 were for a reference.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---

diff --git a/darwin-user/commpage.c b/darwin-user/commpage.c
index f6aa71e058..cc29bddd95 100644
--- a/darwin-user/commpage.c
+++ b/darwin-user/commpage.c
@@ -211,7 +211,7 @@ void do_compare_and_swap32(void *cpu_env, int num)
     uint32_t *value = (uint32_t*)((CPUX86State*)cpu_env)->regs[R_ECX];
     DPRINTF("commpage: compare_and_swap32(%x,new,%p)\n", old, value);
 
-    if(value && old == tswap32(*value))
+    if(old == tswap32(*value))
     {
         uint32_t new = ((CPUX86State*)cpu_env)->regs[R_EDX];
         *value = tswap32(new);