From: Jules Irenge Date: Tue, 7 Apr 2020 03:08:27 +0000 (-0700) Subject: mm/zsmalloc: add missing annotation for pin_tag() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=70c7ec95bece1bd01e25fbc4f17c9262445de417;p=linux.git mm/zsmalloc: add missing annotation for pin_tag() Sparse reports a warning at pin_tag()() warning: context imbalance in pin_tag() - wrong count at exit The root cause is the missing annotation at pin_tag() Add the missing __acquires(bitlock) annotation Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton Acked-by: Minchan Kim Link: http://lkml.kernel.org/r/20200214204741.94112-13-jbi.octave@gmail.com Signed-off-by: Linus Torvalds --- diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 2eab424c8c67c..7bac76ae11b35 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -891,7 +891,7 @@ static inline int trypin_tag(unsigned long handle) return bit_spin_trylock(HANDLE_PIN_BIT, (unsigned long *)handle); } -static void pin_tag(unsigned long handle) +static void pin_tag(unsigned long handle) __acquires(bitlock) { bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle); }