From: Fam Zheng <famz@redhat.com>
Date: Thu, 13 Oct 2016 21:58:26 +0000 (-0400)
Subject: block: Assert that bdrv_release_dirty_bitmap succeeded
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7105007a5c8ae6228d78487e1e382d53863ab2c9;p=qemu.git

block: Assert that bdrv_release_dirty_bitmap succeeded

We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1476395910-8697-7-git-send-email-jsnow@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
---

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 860acc9b5b..31d5296ef7 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -305,6 +305,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
             }
         }
     }
+    if (bitmap) {
+        abort();
+    }
 }
 
 void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)