From: Michael S. Tsirkin <mst@redhat.com>
Date: Fri, 9 Sep 2016 17:56:27 +0000 (+0300)
Subject: virtio-pci: minor refactoring
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=71d19fc51387ba599f6222057fd69c58b3c0ce7e;p=qemu.git

virtio-pci: minor refactoring

!legacy && !modern is shorter than !(legacy || modern).
I also perfer this (less ()s) as a matter of taste.

Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index d70c9865fa..bf19808e87 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1776,7 +1776,7 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error **errp)
         proxy->disable_legacy = pcie_port ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF;
     }
 
-    if (!(virtio_pci_modern(proxy) || virtio_pci_legacy(proxy))) {
+    if (!virtio_pci_modern(proxy) && !virtio_pci_legacy(proxy)) {
         error_setg(errp, "device cannot work as neither modern nor legacy mode"
                    " is enabled");
         error_append_hint(errp, "Set either disable-modern or disable-legacy"