From: Kenneth Lee <klee33@uw.edu>
Date: Fri, 19 Aug 2022 05:42:55 +0000 (-0700)
Subject: ceph: Use kcalloc for allocating multiple elements
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=729c9ad2940e6cc50d7cd2c2bd57f47c189eea9e;p=linux.git

ceph: Use kcalloc for allocating multiple elements

[ Upstream commit aa1d627207cace003163dee24d1c06fa4e910c6b ]

Prefer using kcalloc(a, b) over kzalloc(a * b) as this improves
semantics since kcalloc is intended for allocating an array of memory.

Signed-off-by: Kenneth Lee <klee33@uw.edu>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Stable-dep-of: 5bd76b8de5b7 ("ceph: fix NULL pointer dereference for req->r_session")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 883bb91ee257e..a6e2aaff17dd8 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -2255,7 +2255,7 @@ retry:
 		struct ceph_mds_request *req;
 		int i;
 
-		sessions = kzalloc(max_sessions * sizeof(s), GFP_KERNEL);
+		sessions = kcalloc(max_sessions, sizeof(s), GFP_KERNEL);
 		if (!sessions) {
 			err = -ENOMEM;
 			goto out;