From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Thu, 29 Sep 2011 17:43:28 +0000 (-0400)
Subject: xen/pciback: Do not dereference psdev during printk when it is NULL.
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=72bf809a19d9fc97bfe39bb928149b5e0f202cb6;p=linux.git

xen/pciback: Do not dereference psdev during printk when it is NULL.

.. instead use BUG_ON() as all the callers of the kill_domain_by_device
check for psdev.

Suggested-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 1b474804180a2..3cc3fbe5bf8d7 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -512,12 +512,7 @@ static void kill_domain_by_device(struct pcistub_device *psdev)
 	int err;
 	char nodename[PCI_NODENAME_MAX];
 
-	if (!psdev) {
-		dev_err(&psdev->dev->dev,
-			"device is NULL when do AER recovery/kill_domain\n");
-		return;
-	}
-
+	BUG_ON(!psdev);
 	snprintf(nodename, PCI_NODENAME_MAX, "/local/domain/0/backend/pci/%d/0",
 		psdev->pdev->xdev->otherend_id);