From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 26 Sep 2018 10:39:34 +0000 (+0300)
Subject: 9p: potential NULL dereference
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=72ea0321088df2c41eca8cc6160c24bcceb56ac7;p=linux.git

9p: potential NULL dereference

p9_tag_alloc() is supposed to return error pointers, but we accidentally
return a NULL here.  It would cause a NULL dereference in the caller.

Link: http://lkml.kernel.org/m/20180926103934.GA14535@mwanda
Fixes: 996d5b4db4b1 ("9p: Use a slab for allocating requests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
---

diff --git a/net/9p/client.c b/net/9p/client.c
index 47fa6158a75a4..5f23e18eecc02 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -281,7 +281,7 @@ p9_tag_alloc(struct p9_client *c, int8_t type, unsigned int max_size)
 	int tag;
 
 	if (!req)
-		return NULL;
+		return ERR_PTR(-ENOMEM);
 
 	if (p9_fcall_init(c, &req->tc, alloc_msize))
 		goto free_req;