From: Mirela Rabulea Date: Tue, 6 Apr 2021 17:34:28 +0000 (+0200) Subject: media: imx-jpeg: Fix double free in mxc_jpeg_remove X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7385209770fcb29f31e713e0c3db6a16f51cb8b9;p=linux.git media: imx-jpeg: Fix double free in mxc_jpeg_remove The video_unregister_device already calls video_device_release, so remove video_device_release, to avoid a double free, when removing the module. This showed up in a repeated rmmod/insmod scenario. Signed-off-by: Mirela Rabulea Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index c72024078ff81..03b9264af068d 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -2101,7 +2101,6 @@ static int mxc_jpeg_remove(struct platform_device *pdev) mxc_jpeg_free_slot_data(jpeg, slot); video_unregister_device(jpeg->dec_vdev); - video_device_release(jpeg->dec_vdev); v4l2_m2m_release(jpeg->m2m_dev); v4l2_device_unregister(&jpeg->v4l2_dev); mxc_jpeg_detach_pm_domains(jpeg);