From: Bartosz Golaszewski <bartekgola@gmail.com>
Date: Mon, 27 Feb 2017 12:21:31 +0000 (+0100)
Subject: tests: make struct gu_chip_descr & gu_test private
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=742410000a37cd648aa37bf31ba3c4d05bcf25a5;p=qemu-gpiodev%2Flibgpiod.git

tests: make struct gu_chip_descr & gu_test private

Add an underscore to struct gu_chip_descr & struct gu_test. This
indicates that these structures are for internal use only.

Test cases should use provided helper macros when registering tests.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
---

diff --git a/tests/unit/gpiod-unit.c b/tests/unit/gpiod-unit.c
index bf10248..7baf040 100644
--- a/tests/unit/gpiod-unit.c
+++ b/tests/unit/gpiod-unit.c
@@ -36,8 +36,8 @@ struct test_context {
 };
 
 static struct {
-	struct gu_test *test_list_head;
-	struct gu_test *test_list_tail;
+	struct _gu_test *test_list_head;
+	struct _gu_test *test_list_tail;
 	unsigned int num_tests;
 	unsigned int tests_failed;
 	struct kmod_ctx *module_ctx;
@@ -184,7 +184,7 @@ static void check_gpio_mockup(void)
 	gu_msg("gpio-mockup ok");
 }
 
-static void test_load_module(struct gu_chip_descr *descr)
+static void test_load_module(struct _gu_chip_descr *descr)
 {
 	char *modarg, *tmp_modarg;
 	size_t modarg_len;
@@ -246,7 +246,7 @@ static bool devpath_is_mockup(const char *devpath)
 	return !strncmp(devpath, mockup_devpath, sizeof(mockup_devpath) - 1);
 }
 
-static void test_prepare(struct gu_chip_descr *descr)
+static void test_prepare(struct _gu_chip_descr *descr)
 {
 	const char *devpath, *devnode, *sysname;
 	struct udev_monitor *monitor;
@@ -351,7 +351,7 @@ static void test_teardown(void)
 
 int main(int argc GU_UNUSED, char **argv GU_UNUSED)
 {
-	struct gu_test *test;
+	struct _gu_test *test;
 
 	atexit(module_cleanup);
 
@@ -434,9 +434,9 @@ unsigned int gu_chip_num(unsigned int index)
 	return globals.test_ctx.chips[index]->number;
 }
 
-void _gu_register_test(struct gu_test *test)
+void _gu_register_test(struct _gu_test *test)
 {
-	struct gu_test *tmp;
+	struct _gu_test *tmp;
 
 	if (!globals.test_list_head) {
 		globals.test_list_head = globals.test_list_tail = test;
diff --git a/tests/unit/gpiod-unit.h b/tests/unit/gpiod-unit.h
index 6b6dd3e..8d86c70 100644
--- a/tests/unit/gpiod-unit.h
+++ b/tests/unit/gpiod-unit.h
@@ -23,22 +23,22 @@
 
 typedef void (*gu_test_func)(void);
 
-struct gu_chip_descr {
+struct _gu_chip_descr {
 	unsigned int num_chips;
 	unsigned int *num_lines;
 	bool named_lines;
 };
 
-struct gu_test {
-	struct gu_test *_next;
+struct _gu_test {
+	struct _gu_test *_next;
 
 	const char *name;
 	gu_test_func func;
 
-	struct gu_chip_descr chip_descr;
+	struct _gu_chip_descr chip_descr;
 };
 
-void _gu_register_test(struct gu_test *test);
+void _gu_register_test(struct _gu_test *test);
 void _gu_test_failed(const char *fmt, ...) GU_PRINTF(1, 2);
 
 #define GU_REGISTER_TEST(test)						\
@@ -63,7 +63,7 @@ void _gu_test_failed(const char *fmt, ...) GU_PRINTF(1, 2);
  */
 #define GU_DEFINE_TEST(_a_func, _a_name, _a_named_lines, ...)		\
 	static unsigned int _##_a_func##_lines[] = __VA_ARGS__;		\
-	static struct gu_test _##_a_func##_descr = {			\
+	static struct _gu_test _##_a_func##_descr = {			\
 		.name = _a_name,					\
 		.func = _a_func,					\
 		.chip_descr = {						\