From: Nick Alcock <nick.alcock@oracle.com>
Date: Tue, 7 Mar 2023 18:01:35 +0000 (+0000)
Subject: binfmt_elf: remove MODULE_LICENSE in non-modules
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7435721a4a7b6f51b60c41a2e58075dec3cc0ca8;p=linux.git

binfmt_elf: remove MODULE_LICENSE in non-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---

diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 8a884e795f6a7..0f0d106972406 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -2174,7 +2174,6 @@ static void __exit exit_elf_binfmt(void)
 
 core_initcall(init_elf_binfmt);
 module_exit(exit_elf_binfmt);
-MODULE_LICENSE("GPL");
 
 #ifdef CONFIG_BINFMT_ELF_KUNIT_TEST
 #include "binfmt_elf_test.c"