From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Mon, 16 Sep 2019 14:03:03 +0000 (+0300)
Subject: thunderbolt: Drop unnecessary read when writing LC command in Ice Lake
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=747125db6dcd8bcc21f13d013f6e6a2acade21ee;p=linux.git

thunderbolt: Drop unnecessary read when writing LC command in Ice Lake

The read is not needed as we overwrite the returned value in the next
line anyway so drop it.

Fixes: 3cdb9446a117 ("thunderbolt: Add support for Intel Ice Lake")
Reported-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---

diff --git a/drivers/thunderbolt/nhi_ops.c b/drivers/thunderbolt/nhi_ops.c
index 61cd09cef943d..6795851aac95b 100644
--- a/drivers/thunderbolt/nhi_ops.c
+++ b/drivers/thunderbolt/nhi_ops.c
@@ -80,7 +80,6 @@ static void icl_nhi_lc_mailbox_cmd(struct tb_nhi *nhi, enum icl_lc_mailbox_cmd c
 {
 	u32 data;
 
-	pci_read_config_dword(nhi->pdev, VS_CAP_19, &data);
 	data = (cmd << VS_CAP_19_CMD_SHIFT) & VS_CAP_19_CMD_MASK;
 	pci_write_config_dword(nhi->pdev, VS_CAP_19, data | VS_CAP_19_VALID);
 }