From: Colin Ian King Date: Fri, 8 Oct 2021 09:54:29 +0000 (+0100) Subject: ASoC: rockchip: i2s-tdm: Remove call to rockchip_i2s_ch_to_io X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=74daadc7fde5dc3326ba2158a60c1c028f2e19b9;p=linux.git ASoC: rockchip: i2s-tdm: Remove call to rockchip_i2s_ch_to_io The call to rockchip_i2s_ch_to_io is only useful for its return value which is not being used. The function call also has no side effects, the call is effectively useless and can be removed. Addresses-Coverity: ("Useless call") Signed-off-by: Colin Ian King Message-Id: <20211008095430.62680-1-colin.king@canonical.com> Signed-off-by: Mark Brown --- diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c index b08b150719936..cc5a2f9d39480 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -848,8 +848,6 @@ static int rockchip_i2s_io_multiplex(struct snd_pcm_substream *substream, to_ch_num(val), usable_chs); return -EINVAL; } - - rockchip_i2s_ch_to_io(val, false); } val <<= i2s_tdm->soc_data->grf_shift;