From: Lv Yunlong Date: Tue, 27 Apr 2021 16:22:58 +0000 (-0700) Subject: net:nfc:digital: Fix a double free in digital_tg_recv_dep_req X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=75258586793efc521e5dd52a5bf6c7a4cf7002be;p=linux.git net:nfc:digital: Fix a double free in digital_tg_recv_dep_req In digital_tg_recv_dep_req, it calls nfc_tm_data_received(..,resp). If nfc_tm_data_received() failed, the callee will free the resp via kfree_skb() and return error. But in the exit branch, the resp will be freed again. My patch sets resp to NULL if nfc_tm_data_received() failed, to avoid the double free. Fixes: 1c7a4c24fbfd9 ("NFC Digital: Add target NFC-DEP support") Signed-off-by: Lv Yunlong Signed-off-by: David S. Miller --- diff --git a/net/nfc/digital_dep.c b/net/nfc/digital_dep.c index 1150731126e2a..3982fa084737f 100644 --- a/net/nfc/digital_dep.c +++ b/net/nfc/digital_dep.c @@ -1273,6 +1273,8 @@ static void digital_tg_recv_dep_req(struct nfc_digital_dev *ddev, void *arg, } rc = nfc_tm_data_received(ddev->nfc_dev, resp); + if (rc) + resp = NULL; exit: kfree_skb(ddev->chaining_skb);