From: Yang Li Date: Wed, 12 Jul 2023 06:48:32 +0000 (+0800) Subject: scsi: ufs: ufs-mediatek: Remove redundant dev_err() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=75aa298739fdff5dac98e5a6e8b9106c1297d6f0;p=linux.git scsi: ufs: ufs-mediatek: Remove redundant dev_err() There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 Signed-off-by: Yang Li Link: https://lore.kernel.org/r/20230712064832.44188-1-yang.lee@linux.alibaba.com Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Martin K. Petersen --- diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 786b1469eb52c..b499eade957ee 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -861,7 +861,6 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba) irq = platform_get_irq(pdev, i + 1); if (irq < 0) { host->mcq_intr_info[i].irq = MTK_MCQ_INVALID_IRQ; - dev_err(hba->dev, "get platform mcq irq fail: %d\n", i); goto failed; } host->mcq_intr_info[i].hba = hba;