From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 28 May 2014 09:16:55 +0000 (+0200)
Subject: block/vvfat: Plug memory leak in enable_write_target()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=75e347d66ab81944b5b657d17cc90ef92af3f016;p=qemu.git

block/vvfat: Plug memory leak in enable_write_target()

I figure the leak originated in bdrv_create2(), and was duplicated
into callers when commit 91a073a dropped that function.  Looks like
the other places have since been fixed.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/block/vvfat.c b/block/vvfat.c
index 8f5114bd16..811b39c1ca 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2929,6 +2929,7 @@ static int enable_write_target(BDRVVVFATState *s, Error **errp)
     set_option_parameter(options, BLOCK_OPT_BACKING_FILE, "fat:");
 
     ret = bdrv_create(bdrv_qcow, s->qcow_filename, options, errp);
+    free_option_parameters(options);
     if (ret < 0) {
         goto err;
     }