From: Geert Uytterhoeven Date: Mon, 8 Jun 2020 08:06:36 +0000 (+0200) Subject: Revert "sh: add missing EXPORT_SYMBOL() for __delay" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7619f957dc8cb8b2db3be21254d758c16e025961;p=linux.git Revert "sh: add missing EXPORT_SYMBOL() for __delay" This reverts commit d1f56f318d234fc5db230af2f3e0088f689ab3c0. __delay() is an internal implementation detail on several architectures. Drivers should not call __delay() directly, as it has non-standardized semantics, or may not even exist. Hence there is no need to export __delay() to modules. See also include/asm-generic/delay.h: /* Undefined functions to get compile-time errors */ ... extern void __delay(unsigned long loops); Signed-off-by: Geert Uytterhoeven Signed-off-by: Rich Felker --- diff --git a/arch/sh/lib/delay.c b/arch/sh/lib/delay.c index 540e670dbafcd..dad8e6a54906b 100644 --- a/arch/sh/lib/delay.c +++ b/arch/sh/lib/delay.c @@ -29,7 +29,6 @@ void __delay(unsigned long loops) : "0" (loops) : "t"); } -EXPORT_SYMBOL(__delay); inline void __const_udelay(unsigned long xloops) {