From: Jiri Pirko Date: Fri, 25 Nov 2022 10:02:55 +0000 (+0100) Subject: net: devlink: add WARN_ON_ONCE to check return value of unregister_netdevice_notifier... X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7666dbec7268458505d44ef3ae22fd9181c09b01;p=linux.git net: devlink: add WARN_ON_ONCE to check return value of unregister_netdevice_notifier_net() call As the return value is not 0 only in case there is no such notifier block registered, add a WARN_ON_ONCE() to yell about it. Suggested-by: Ido Schimmel Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel Link: https://lore.kernel.org/r/20221125100255.1786741-1-jiri@resnulli.us Signed-off-by: Paolo Abeni --- diff --git a/net/core/devlink.c b/net/core/devlink.c index cea154ddce7aa..0e10a8a68c5e9 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -9907,8 +9907,8 @@ void devlink_free(struct devlink *devlink) xa_destroy(&devlink->snapshot_ids); - unregister_netdevice_notifier_net(devlink_net(devlink), - &devlink->netdevice_nb); + WARN_ON_ONCE(unregister_netdevice_notifier_net(devlink_net(devlink), + &devlink->netdevice_nb)); xa_erase(&devlinks, devlink->index);