From: Jaegeuk Kim Date: Sat, 4 Dec 2021 17:55:35 +0000 (-0800) Subject: f2fs: avoid duplicate call of mark_inode_dirty X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=766c663933bec1068a6041f05bf31d39606bc2e8;p=linux.git f2fs: avoid duplicate call of mark_inode_dirty Let's check the condition first before set|clear bit. Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index ac6dda6c4c5a4..cbc73bd71dadf 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3115,12 +3115,16 @@ static inline int is_file(struct inode *inode, int type) static inline void set_file(struct inode *inode, int type) { + if (is_file(inode, type)) + return; F2FS_I(inode)->i_advise |= type; f2fs_mark_inode_dirty_sync(inode, true); } static inline void clear_file(struct inode *inode, int type) { + if (!is_file(inode, type)) + return; F2FS_I(inode)->i_advise &= ~type; f2fs_mark_inode_dirty_sync(inode, true); }