From: Jiapeng Chong Date: Thu, 2 Dec 2021 10:07:59 +0000 (+0800) Subject: RDMA/siw: Use max() instead of doing it manually X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=76937fa552008405d7dd43143545794542623108;p=linux.git RDMA/siw: Use max() instead of doing it manually Fix following coccicheck warning: ./drivers/infiniband/sw/siw/siw_verbs.c:665:28-29: WARNING opportunity for max(). Link: https://lore.kernel.org/r/1638439679-114250-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Bernard Metzler Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c index d15a1f9c59f03..a3dd2cb6d5c98 100644 --- a/drivers/infiniband/sw/siw/siw_verbs.c +++ b/drivers/infiniband/sw/siw/siw_verbs.c @@ -662,7 +662,7 @@ static int siw_copy_inline_sgl(const struct ib_send_wr *core_wr, kbuf += core_sge->length; core_sge++; } - sqe->sge[0].length = bytes > 0 ? bytes : 0; + sqe->sge[0].length = max(bytes, 0); sqe->num_sge = bytes > 0 ? 1 : 0; return bytes;