From: Breno Leitao Date: Tue, 5 Mar 2024 17:29:10 +0000 (-0800) Subject: net: geneve: Remove generic .ndo_get_stats64 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=771d791d7ccf5397b75ba7257765aeb39f27c758;p=linux.git net: geneve: Remove generic .ndo_get_stats64 Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/20240305172911.502058-2-leitao@debian.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index dc88d5600e2dd..ff0d7bdaa4ee2 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -1114,7 +1114,6 @@ static const struct net_device_ops geneve_netdev_ops = { .ndo_open = geneve_open, .ndo_stop = geneve_stop, .ndo_start_xmit = geneve_xmit, - .ndo_get_stats64 = dev_get_tstats64, .ndo_change_mtu = geneve_change_mtu, .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = eth_mac_addr,