From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 12 Jul 2016 12:02:17 +0000 (+0100)
Subject: linux-user: Check dump_write() return in elf_core_dump()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=772034b63e9c0caf6c92e31413f2d8df2ee69c88;p=qemu.git

linux-user: Check dump_write() return in elf_core_dump()

One of the calls to dump_write() in elf_core_dump() was missing
a check for failure (spotted by Coverity). Add the check to
bring it into line with the other calls from this function.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index e9a3882bef..0d07b85cb8 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3050,7 +3050,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
         phdr.p_align = ELF_EXEC_PAGESIZE;
 
         bswap_phdr(&phdr, 1);
-        dump_write(fd, &phdr, sizeof (phdr));
+        if (dump_write(fd, &phdr, sizeof(phdr)) != 0) {
+            goto out;
+        }
     }
 
     /*