From: Rouven Czerwinski Date: Wed, 16 Jun 2021 12:53:31 +0000 (+0200) Subject: regulator: fixed: use dev_err_probe for gpio X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7740ab84c13e32002742106afd443a4ca7fe3918;p=linux.git regulator: fixed: use dev_err_probe for gpio Instead of returning the the PTR_ERR directly, use dev_err_probe which will also correctly set the deferred probe reason in /sys/kernel/debug/deferred_devices, making it easier to debug missing devices on the system. Signed-off-by: Rouven Czerwinski Link: https://lore.kernel.org/r/20210616125331.153414-1-r.czerwinski@pengutronix.de Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 02ad83153e19a..78f3a938b39bb 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -271,7 +271,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) */ cfg.ena_gpiod = gpiod_get_optional(&pdev->dev, NULL, gflags); if (IS_ERR(cfg.ena_gpiod)) - return PTR_ERR(cfg.ena_gpiod); + return dev_err_probe(&pdev->dev, PTR_ERR(cfg.ena_gpiod), + "can't get GPIO\n"); cfg.dev = &pdev->dev; cfg.init_data = config->init_data;