From: Igor Mammedov <imammedo@redhat.com>
Date: Fri, 26 Sep 2014 09:28:37 +0000 (+0000)
Subject: usb-storage: Drop not needed "allow_hotplug = 0"
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=77de4a09c6d3d1e4fabcc0eb6cfdb9ea5a1616d5;p=qemu.git

usb-storage: Drop not needed "allow_hotplug = 0"

Drop useless hack that disables hotplug on bus, after backend
storage was added to it, by setting "allow_hotplug = 0". Even
if bus is hotpluggable, it won't be possible to add another
SCSI device to bus since its realize will fail early with
error "no free target" in scsi_qdev_realize() method.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index bccaa3fbf4..b005783fdf 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error **errp)
         error_propagate(errp, err);
         return;
     }
-    s->bus.qbus.allow_hotplug = 0;
     usb_msd_handle_reset(dev);
 
     if (bdrv_key_required(bs)) {