From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date: Sat, 15 Apr 2023 10:42:57 +0000 (+0200)
Subject: w1: ds2482: do not use assignment in if condition
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=787e19ae1fa96cfbbb943e647253e966b4d53407;p=linux.git

w1: ds2482: do not use assignment in if condition

Assignments in if condition are less readable and error-prone.  Fixes
also checkpatch warning:

  ERROR: do not use assignment in if condition

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20230415104304.104134-9-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
index cc5938fb62390..c1de8a92e144b 100644
--- a/drivers/w1/masters/ds2482.c
+++ b/drivers/w1/masters/ds2482.c
@@ -451,7 +451,8 @@ static int ds2482_probe(struct i2c_client *client)
 				     I2C_FUNC_SMBUS_BYTE))
 		return -ENODEV;
 
-	if (!(data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL))) {
+	data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL);
+	if (!data) {
 		err = -ENOMEM;
 		goto exit;
 	}