From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Wed, 29 May 2024 20:28:41 +0000 (-0400)
Subject: bcachefs: Fix failure to return error on misaligned dio write
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7b038b564b3e2a752d2211e7b0c3c29fd2f6e197;p=linux.git

bcachefs: Fix failure to return error on misaligned dio write

This was reported as an error when running coreutils shred.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/fs-io-direct.c b/fs/bcachefs/fs-io-direct.c
index 09d21aef879af..049b61bc9a5b3 100644
--- a/fs/bcachefs/fs-io-direct.c
+++ b/fs/bcachefs/fs-io-direct.c
@@ -609,8 +609,10 @@ ssize_t bch2_direct_write(struct kiocb *req, struct iov_iter *iter)
 	if (unlikely(ret))
 		goto err_put_write_ref;
 
-	if (unlikely((req->ki_pos|iter->count) & (block_bytes(c) - 1)))
+	if (unlikely((req->ki_pos|iter->count) & (block_bytes(c) - 1))) {
+		ret = -EINVAL;
 		goto err_put_write_ref;
+	}
 
 	inode_dio_begin(&inode->v);
 	bch2_pagecache_block_get(inode);