From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 22 Apr 2010 01:41:24 +0000 (+0200)
Subject: bt-l2cap: fix if statement with empty body, spotted by clang
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7b1df88f284f462ecb236931ad863a815f243195;p=qemu.git

bt-l2cap: fix if statement with empty body, spotted by clang

Fix clang error:
  CC    bt-l2cap.o
/src/qemu/hw/bt-l2cap.c:1000:41: error: if statement has empty body
[-Wempty-body]
            /* TODO: Signal an error? */;

This means that l2cap_sframe_in() may now get called.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Andrew Zaborowski <balrogg@gmail.com>
---

diff --git a/hw/bt-l2cap.c b/hw/bt-l2cap.c
index 70d731e61b..7e2f668e5a 100644
--- a/hw/bt-l2cap.c
+++ b/hw/bt-l2cap.c
@@ -996,10 +996,10 @@ static void l2cap_iframe_in(struct l2cap_chan_s *ch, uint16_t cid,
         l2cap_rexmit_enable(ch, !(hdr->data[0] >> 7));
 
     if (hdr->data[0] & 1) {
-        if (len != 4)
-            /* TODO: Signal an error? */;
+        if (len != 4) {
+            /* TODO: Signal an error? */
             return;
-
+        }
         return l2cap_sframe_in(ch, le16_to_cpup((void *) hdr->data));
     }