From: Sergio Paracuellos Date: Fri, 6 Apr 2018 12:37:39 +0000 (+0200) Subject: staging: ks7010: change ETHER_HDR_SIZE definition to use the size of struct ether_hdr X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7ba5800b0df6cc8a65b3db83fd7a2cb4426c2890;p=linux.git staging: ks7010: change ETHER_HDR_SIZE definition to use the size of struct ether_hdr This commit changes ETHER_HDR_SIZE definition which is a hardcoded number using the size of the structure ether_hdr which is the one for what this definition has been created. This improves readability and makes clear the intention of this definition along the code. Signed-off-by: Sergio Paracuellos Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index 3a5fade41cd93..d918742f02313 100644 --- a/drivers/staging/ks7010/eap_packet.h +++ b/drivers/staging/ks7010/eap_packet.h @@ -6,8 +6,6 @@ #include #include -#define ETHER_HDR_SIZE 20 - struct ether_hdr { unsigned char h_dest[ETH_ALEN]; /* destination eth addr */ unsigned char h_source[ETH_ALEN]; /* source ether addr */ @@ -19,6 +17,8 @@ struct ether_hdr { /* followed by length octets of data */ } __packed; +#define ETHER_HDR_SIZE sizeof(struct ether_hdr) + struct ieee802_1x_hdr { unsigned char version; unsigned char type;