From: Eric W. Biederman <ebiederm@xmission.com>
Date: Tue, 8 Mar 2022 19:01:19 +0000 (-0600)
Subject: coredump: Remove the WARN_ON in dump_vma_snapshot
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7ba958df64493aa8fb3af315db5095711a0b3589;p=linux.git

coredump: Remove the WARN_ON in dump_vma_snapshot

commit 49c1866348f364478a0c4d3dd13fd08bb82d3a5b upstream.

The condition is impossible and to the best of my knowledge has never
triggered.

We are in deep trouble if that conditions happens and we walk past
the end of our allocated array.

So delete the WARN_ON and the code that makes it look like the kernel
can handle the case of walking past the end of it's vma_meta array.

Reviewed-by: Jann Horn <jannh@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/coredump.c b/fs/coredump.c
index 64e2ce8974200..e95fea3beaeb2 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -1151,12 +1151,6 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
 
 	mmap_write_unlock(mm);
 
-	if (WARN_ON(i != cprm->vma_count)) {
-		kvfree(cprm->vma_meta);
-		return false;
-	}
-
-
 	for (i = 0; i < cprm->vma_count; i++) {
 		struct core_vma_metadata *m = cprm->vma_meta + i;