From: Michal Vokáč Date: Mon, 8 Oct 2018 10:57:36 +0000 (+0200) Subject: video: ssd1307fb: Use gpiod_set_value_cansleep() for reset X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7d1b8d7a858024bd6a1dca206646fbcab5785220;p=linux.git video: ssd1307fb: Use gpiod_set_value_cansleep() for reset The reset signal can be produced by GPIO expander that can sleep. In that case the probe function fails. Allow using GPIO expanders for the reset signal by using the non-atomic gpiod_set_value_cansleep() function. Signed-off-by: Michal Vokáč Reviewed-by: Fabio Estevam Cc: Shawn Guo Cc: Rob Herring Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 6439231f2db22..4061a20cfe24a 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -667,9 +667,9 @@ static int ssd1307fb_probe(struct i2c_client *client, if (par->reset) { /* Reset the screen */ - gpiod_set_value(par->reset, 0); + gpiod_set_value_cansleep(par->reset, 0); udelay(4); - gpiod_set_value(par->reset, 1); + gpiod_set_value_cansleep(par->reset, 1); udelay(4); }