From: Krzysztof Kozlowski Date: Mon, 13 Mar 2023 14:49:09 +0000 (+0100) Subject: media: samsung: exynos4-is: drop simple-bus from compatibles X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7d3b26da468d7b5ea180b5fdcdcc3c96c3467a7e;p=linux.git media: samsung: exynos4-is: drop simple-bus from compatibles The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 22baa429ed5db..6839007edf1d6 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev;