From: Li Nan Date: Sat, 1 Jul 2023 08:05:27 +0000 (+0800) Subject: md/raid10: check replacement and rdev to prevent submit the same io twice X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7e85c41b9e1df9192c225afd7cfec8dcad137feb;p=linux.git md/raid10: check replacement and rdev to prevent submit the same io twice After commit 4ca40c2ce099 ("md/raid10: Allow replacement device to be replace old drive."), 'rdev' and 'replacement' could appear to be identical. There are already checks for that in wait_blocked_dev() and raid10_write_request(). Add check for raid10_handle_discard() now. Signed-off-by: Li Nan Link: https://lore.kernel.org/r/20230701080529.2684932-2-linan666@huaweicloud.com Signed-off-by: Song Liu --- diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 757687fb90a7a..60963449d3f50 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1785,6 +1785,8 @@ retry_discard: r10_bio->devs[disk].bio = NULL; r10_bio->devs[disk].repl_bio = NULL; + if (rdev == rrdev) + rrdev = NULL; if (rdev && (test_bit(Faulty, &rdev->flags))) rdev = NULL; if (rrdev && (test_bit(Faulty, &rrdev->flags)))