From: Alexandre Belloni Date: Sat, 14 Dec 2019 22:02:56 +0000 (+0100) Subject: rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLR X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7e890a0f0e4d777d8292539a0609d3aeef6e6da4;p=linux.git rtc: rv8803: avoid clearing RV8803_FLAG_V2F in RTC_VL_CLR Stop clearing RV8803_FLAG_V2F in RTC_VL_CLR because it is a disservice to userspace as it removes the important information that the RTC data is invalid. This may lead userspace to set an invalid system time later on. Link: https://lore.kernel.org/r/20191214220259.621996-15-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 4960f0a2b249a..ed92116bdfa07 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -440,7 +440,7 @@ static int rv8803_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) return flags; } - flags &= ~(RV8803_FLAG_V1F | RV8803_FLAG_V2F); + flags &= ~RV8803_FLAG_V1F; ret = rv8803_write_reg(client, RV8803_FLAG, flags); mutex_unlock(&rv8803->flags_lock); if (ret)