From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Thu, 25 Aug 2022 12:27:25 +0000 (+0200)
Subject: sched/fair: Move call to list_last_entry() in detach_tasks
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7e9518baed4cef76dbfa07cbffbae1e6dbc87be6;p=linux.git

sched/fair: Move call to list_last_entry() in detach_tasks

Move the call to list_last_entry() in detach_tasks() after testing
loop_max and loop_break.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220825122726.20819-4-vincent.guittot@linaro.org
---

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 7b3a58fcb4368..5ffec43706023 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8044,8 +8044,6 @@ static int detach_tasks(struct lb_env *env)
 		if (env->idle != CPU_NOT_IDLE && env->src_rq->nr_running <= 1)
 			break;
 
-		p = list_last_entry(tasks, struct task_struct, se.group_node);
-
 		env->loop++;
 		/*
 		 * We've more or less seen every task there is, call it quits
@@ -8062,6 +8060,8 @@ static int detach_tasks(struct lb_env *env)
 			break;
 		}
 
+		p = list_last_entry(tasks, struct task_struct, se.group_node);
+
 		if (!can_migrate_task(p, env))
 			goto next;