From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Fri, 16 Feb 2018 15:40:24 +0000 (+0200)
Subject: platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7f166addbebdcaeefe36997d5b8dceb96c5619fa;p=linux.git

platform/x86: wmi: Replace kmalloc + sprintf() with kasprintf()

kasprintf() does the job of two: kmalloc() and sprintf().
Replace two calls with one.

Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index c0c8945603cbb..4e76ffcb5394d 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -933,12 +933,11 @@ static int wmi_dev_probe(struct device *dev)
 			goto probe_failure;
 		}
 
-		buf = kmalloc(strlen(wdriver->driver.name) + 5, GFP_KERNEL);
+		buf = kasprintf(GFP_KERNEL, "wmi/%s", wdriver->driver.name);
 		if (!buf) {
 			ret = -ENOMEM;
 			goto probe_string_failure;
 		}
-		sprintf(buf, "wmi/%s", wdriver->driver.name);
 		wblock->char_dev.minor = MISC_DYNAMIC_MINOR;
 		wblock->char_dev.name = buf;
 		wblock->char_dev.fops = &wmi_fops;