From: Peter Maydell Date: Thu, 13 Oct 2011 17:45:37 +0000 (+0100) Subject: compatfd.c: Don't pass NULL pointer to SYS_signalfd X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=7f84c1272b601be88daeb828ec1890890c7aae25;p=qemu.git compatfd.c: Don't pass NULL pointer to SYS_signalfd Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Signed-off-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Andrzej Zaborowski --- diff --git a/compatfd.c b/compatfd.c index 31654c62a6..02306a4f71 100644 --- a/compatfd.c +++ b/compatfd.c @@ -119,9 +119,17 @@ int qemu_signalfd(const sigset_t *mask) bool qemu_signalfd_available(void) { #ifdef CONFIG_SIGNALFD + sigset_t mask; + int fd; + bool ok; + sigemptyset(&mask); errno = 0; - syscall(SYS_signalfd, -1, NULL, _NSIG / 8); - return errno != ENOSYS; + fd = syscall(SYS_signalfd, -1, &mask, _NSIG / 8); + ok = (errno != ENOSYS); + if (fd >= 0) { + close(fd); + } + return ok; #else return false; #endif